From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19352 invoked by alias); 22 Dec 2007 17:39:13 -0000 Received: (qmail 19341 invoked by uid 22791); 22 Dec 2007 17:39:12 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 22 Dec 2007 17:39:05 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 4DEA998243; Sat, 22 Dec 2007 17:39:04 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 311B19801E; Sat, 22 Dec 2007 17:39:04 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J68JT-0005jv-56; Sat, 22 Dec 2007 12:39:03 -0500 Date: Sat, 22 Dec 2007 18:05:00 -0000 From: Daniel Jacobowitz To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [RFC/RFA] continue stepping if landed in new range of same line Message-ID: <20071222173903.GA22038@caradoc.them.org> Mail-Followup-To: Joel Brobecker , gdb-patches@sourceware.org References: <20071219075903.GA6184@adacore.com> <20071219141812.GA21072@caradoc.them.org> <20071220052617.GE6154@adacore.com> <20071220140023.GB7244@caradoc.them.org> <20071221060730.GM6184@adacore.com> <20071221132401.GA22244@caradoc.them.org> <20071222060137.GS6154@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071222060137.GS6154@adacore.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00396.txt.bz2 On Sat, Dec 22, 2007 at 10:01:37AM +0400, Joel Brobecker wrote: > I wouldn't mind removing the code altogether; as a bonus it would also > reduce the size of handle_inferior_event. I can send a patch now, or > I can poll users on gdb@ and see what they think... Honestly, given > the likeliness of one-line functions, I'd just say it's not very > important to keep that special case. There are a few one line functions in the testsuite. In my opinion / experience, they cover all the cases that really need to be covered; if we find an omission, we can add some more tests :-) > 2007-12-22 Joel Brobecker > > * infrun.c (handle_inferior_event): Remove code that made us > stop when stepping into the last line of the current function. > > Tested on x86-linux, no regression. This is OK as far as I'm concerned. And I am always in favor of simplifying handle_inferior_event. -- Daniel Jacobowitz CodeSourcery