From: Joel Brobecker <brobecker@adacore.com>
To: Jim Blandy <jimb@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: Use gdb_get_line_number in asm-source.exp
Date: Sat, 22 Dec 2007 06:39:00 -0000 [thread overview]
Message-ID: <20071222062604.GU6154@adacore.com> (raw)
In-Reply-To: <m3sl1v8dwh.fsf@codesourcery.com>
Hi Jim,
> 2007-12-21 Jim Blandy <jimb@codesourcery.com>
>
> * gdb.asm/asm-source.exp: Use gdb_get_line_number, instead of
> hard-coding source line numbers into the test.
> * gdb.asm/asmsrc1.s, gdb.asm/asmsrc2.s: Add comments for
> gdb_get_line_number to find.
FWIW, this looks good to me. There is just ...
> comment "Call a subroutine in another file."
>
> + comment "mark: call foo2"
> gdbasm_call foo2
The indenting here that looks a bit strange.
--
Joel
next prev parent reply other threads:[~2007-12-22 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 6:23 Jim Blandy
2007-12-22 6:39 ` Joel Brobecker [this message]
2007-12-22 9:59 ` Jim Blandy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071222062604.GU6154@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox