From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5328 invoked by alias); 22 Dec 2007 06:27:02 -0000 Received: (qmail 5311 invoked by uid 22791); 22 Dec 2007 06:27:02 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 22 Dec 2007 06:26:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id DABBF2A96AC; Sat, 22 Dec 2007 01:26:56 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id DGtKSvztBvxD; Sat, 22 Dec 2007 01:26:56 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5B9412A96A2; Sat, 22 Dec 2007 01:26:56 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 8BFDAE7ACA; Sat, 22 Dec 2007 10:26:04 +0400 (RET) Date: Sat, 22 Dec 2007 06:39:00 -0000 From: Joel Brobecker To: Jim Blandy Cc: gdb-patches@sourceware.org Subject: Re: RFA: Use gdb_get_line_number in asm-source.exp Message-ID: <20071222062604.GU6154@adacore.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00392.txt.bz2 Hi Jim, > 2007-12-21 Jim Blandy > > * gdb.asm/asm-source.exp: Use gdb_get_line_number, instead of > hard-coding source line numbers into the test. > * gdb.asm/asmsrc1.s, gdb.asm/asmsrc2.s: Add comments for > gdb_get_line_number to find. FWIW, this looks good to me. There is just ... > comment "Call a subroutine in another file." > > + comment "mark: call foo2" > gdbasm_call foo2 The indenting here that looks a bit strange. -- Joel