From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] language.h minor cleanup
Date: Mon, 17 Dec 2007 10:46:00 -0000 [thread overview]
Message-ID: <200712171040.lBHAe0SM002161@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20071217070301.GE32623@adacore.com> (message from Joel Brobecker on Mon, 17 Dec 2007 11:03:01 +0400)
> Date: Mon, 17 Dec 2007 11:03:01 +0400
> From: Joel Brobecker <brobecker@adacore.com>
>
> Hello,
>
> This is something I noticed while working on the "struct parse_context"
> task: There was one commented-out enum declaration that I decommented,
As far as I know the comment:
> -/* enum exp_opcode; ANSI's `wisdom' didn't include forward enum decls. */
is right, so you shouldn't have comitted this :(. Perhaps it is now a
GCC extension to allow these, but as far as I remember older versions
of GCC didn't accept this.
In that pas we simply moved these enums to defs.h, which should always
be included before any other headers.
Mark
next prev parent reply other threads:[~2007-12-17 10:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-17 7:14 Joel Brobecker
2007-12-17 10:46 ` Mark Kettenis [this message]
2007-12-17 11:23 ` Joel Brobecker
2007-12-17 13:31 ` Daniel Jacobowitz
2007-12-17 14:22 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712171040.lBHAe0SM002161@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox