From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11672 invoked by alias); 17 Dec 2007 10:40:35 -0000 Received: (qmail 11663 invoked by uid 22791); 17 Dec 2007 10:40:35 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 10:40:27 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.1/8.14.0) with ESMTP id lBHAe072025336; Mon, 17 Dec 2007 11:40:01 +0100 (CET) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id lBHAe0SM002161; Mon, 17 Dec 2007 11:40:00 +0100 (CET) Date: Mon, 17 Dec 2007 10:46:00 -0000 Message-Id: <200712171040.lBHAe0SM002161@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: brobecker@adacore.com CC: gdb-patches@sourceware.org In-reply-to: <20071217070301.GE32623@adacore.com> (message from Joel Brobecker on Mon, 17 Dec 2007 11:03:01 +0400) Subject: Re: [commit] language.h minor cleanup References: <20071217070301.GE32623@adacore.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00262.txt.bz2 > Date: Mon, 17 Dec 2007 11:03:01 +0400 > From: Joel Brobecker > > Hello, > > This is something I noticed while working on the "struct parse_context" > task: There was one commented-out enum declaration that I decommented, As far as I know the comment: > -/* enum exp_opcode; ANSI's `wisdom' didn't include forward enum decls. */ is right, so you shouldn't have comitted this :(. Perhaps it is now a GCC extension to allow these, but as far as I remember older versions of GCC didn't accept this. In that pas we simply moved these enums to defs.h, which should always be included before any other headers. Mark