From: Daniel Jacobowitz <drow@false.org>
To: Vladimir Prus <vladimir@codesourcery.com>
Cc: Andreas Schwab <schwab@suse.de>, gdb-patches@sources.redhat.com
Subject: Re: [RFA] Refactor bpstat_stop_status.
Date: Mon, 17 Dec 2007 00:01:00 -0000 [thread overview]
Message-ID: <20071216230108.GB8814@caradoc.them.org> (raw)
In-Reply-To: <200712162210.28832.vladimir@codesourcery.com>
On Sun, Dec 16, 2007 at 10:10:28PM +0300, Vladimir Prus wrote:
> * breakpoint.c (check_location)
> (check_watchpoint, check_breakpoint_conditions):
> New, extracted from bpstat_stop_status.
> (bpstat_stop_status): Use the above.
The patch seems fine, but these function names are too generic - they
say what they are checking, but not what they are checking for.
There's already a watchpoint_check which does something different
from check_watchpoint.
How about a bp_stop_ prefix? Or anything else that makes it clearer
what they're for.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-12-16 23:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-16 18:38 Vladimir Prus
2007-12-16 18:46 ` Andreas Schwab
2007-12-16 20:05 ` Vladimir Prus
2007-12-17 0:01 ` Daniel Jacobowitz [this message]
2008-04-24 14:08 ` Vladimir Prus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071216230108.GB8814@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=schwab@suse.de \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox