From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31041 invoked by alias); 16 Dec 2007 23:01:29 -0000 Received: (qmail 31010 invoked by uid 22791); 16 Dec 2007 23:01:17 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Dec 2007 23:01:11 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6BD2598129; Sun, 16 Dec 2007 23:01:09 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 230BE9811F; Sun, 16 Dec 2007 23:01:09 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J42Ts-0002Nm-ID; Sun, 16 Dec 2007 18:01:08 -0500 Date: Mon, 17 Dec 2007 00:01:00 -0000 From: Daniel Jacobowitz To: Vladimir Prus Cc: Andreas Schwab , gdb-patches@sources.redhat.com Subject: Re: [RFA] Refactor bpstat_stop_status. Message-ID: <20071216230108.GB8814@caradoc.them.org> Mail-Followup-To: Vladimir Prus , Andreas Schwab , gdb-patches@sources.redhat.com References: <200712162115.00462.vladimir@codesourcery.com> <200712162210.28832.vladimir@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200712162210.28832.vladimir@codesourcery.com> User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00244.txt.bz2 On Sun, Dec 16, 2007 at 10:10:28PM +0300, Vladimir Prus wrote: > * breakpoint.c (check_location) > (check_watchpoint, check_breakpoint_conditions): > New, extracted from bpstat_stop_status. > (bpstat_stop_status): Use the above. The patch seems fine, but these function names are too generic - they say what they are checking, but not what they are checking for. There's already a watchpoint_check which does something different from check_watchpoint. How about a bp_stop_ prefix? Or anything else that makes it clearer what they're for. -- Daniel Jacobowitz CodeSourcery