From: Daniel Jacobowitz <drow@false.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org, Nigel Stephens <nigel@mips.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: utils.c: Sign-extend addresses if required by the target
Date: Sun, 16 Dec 2007 21:43:00 -0000 [thread overview]
Message-ID: <20071216213324.GB2618@caradoc.them.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0711221606400.15819@perivale.mips.com>
On Thu, Nov 22, 2007 at 04:25:18PM +0000, Maciej W. Rozycki wrote:
> 2007-11-22 Nigel Stephens <nigel@mips.com>
> Maciej W. Rozycki <macro@mips.com>
>
> * utils.c (string_to_core_addr): If executable format indicates
> that addresses should be sign-extended and there are only 8 hex
> digits in the address, then do so.
> * Makefile.in (utils.o): Depend on $(gdbcore_h).
>
> OK to apply?
OK. This routine is used by MI, but should not be - a long term TODO
item is to change the way we present frame IDs to MI frontends to not
be based on the stack pointer, and then its use will go away. But
that's not going to happen too soon.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-12-16 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 16:25 Maciej W. Rozycki
2007-12-16 21:43 ` Daniel Jacobowitz [this message]
2007-12-17 17:47 ` Maciej W. Rozycki
2007-12-17 17:50 ` Daniel Jacobowitz
2007-12-17 18:35 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071216213324.GB2618@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
--cc=nigel@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox