From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20440 invoked by alias); 16 Dec 2007 21:33:37 -0000 Received: (qmail 20432 invoked by uid 22791); 16 Dec 2007 21:33:37 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 16 Dec 2007 21:33:27 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 2D85A98129; Sun, 16 Dec 2007 21:33:25 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 10E9F9811F; Sun, 16 Dec 2007 21:33:25 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J416y-00010o-CG; Sun, 16 Dec 2007 16:33:24 -0500 Date: Sun, 16 Dec 2007 21:43:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, Nigel Stephens , "Maciej W. Rozycki" Subject: Re: utils.c: Sign-extend addresses if required by the target Message-ID: <20071216213324.GB2618@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, Nigel Stephens , "Maciej W. Rozycki" References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00229.txt.bz2 On Thu, Nov 22, 2007 at 04:25:18PM +0000, Maciej W. Rozycki wrote: > 2007-11-22 Nigel Stephens > Maciej W. Rozycki > > * utils.c (string_to_core_addr): If executable format indicates > that addresses should be sign-extended and there are only 8 hex > digits in the address, then do so. > * Makefile.in (utils.o): Depend on $(gdbcore_h). > > OK to apply? OK. This routine is used by MI, but should not be - a long term TODO item is to change the way we present frame IDs to MI frontends to not be based on the stack pointer, and then its use will go away. But that's not going to happen too soon. -- Daniel Jacobowitz CodeSourcery