Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Michael Snyder <msnyder@specifix.com>,
		Mark Kettenis <mark.kettenis@xs4all.nl>,
	gdb-patches@sourceware.org
Subject: Re: [patch] fileio.exp FAILs if run as root
Date: Tue, 11 Dec 2007 18:38:00 -0000	[thread overview]
Message-ID: <20071211175423.GA8014@caradoc.them.org> (raw)
In-Reply-To: <20071211174626.GA15092@host0.dyn.jankratochvil.net>

On Tue, Dec 11, 2007 at 06:46:26PM +0100, Jan Kratochvil wrote:
> There are various warnings around, at least I see now on the console
> 	WARNING: Couldn't find the global config file.
> 
> but apparently nobody cares (do you also see this warning?).  I had to start

It comes from DejaGNU.  There's nothing much we can do about it; set
DEJAGNU in your environment to point to a local site.exp, and it will
go away.

> There are multiple possibilities:
> 
> (1) Keeping there setuid() before somebody complains it does not work.
>     http://sources.redhat.com/ml/gdb-patches/2007-12/msg00135.html
> 
> (2) Pointing me/anyone at the system where this setuid() code does not work.

It will not work on any of the systems the testcase was designed for,
i.e. those which use the remote File I/O protocol for file operations.

> (3) Skipping (not FAILing) the two tests known they FAIL on the 'root' run.
> 
> (4) Disabling running the testsuite as 'root'.
> 
> (5) Giving just a warning during the start.
> 
> (6) I am too dumb to become a GDB user.
> 
> more?

Just ignoring the two failures if you need to run as root for some
reason, or xfailing them locally, IMO.  I think a warning is quite
sufficient.  Perhaps in the FAIL message.

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-12-11 17:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-08 18:58 Jan Kratochvil
2007-12-08 19:13 ` Mark Kettenis
2007-12-09  1:19   ` Jan Kratochvil
2007-12-11 17:46     ` Michael Snyder
2007-12-11 17:54       ` Jan Kratochvil
2007-12-11 18:38         ` Daniel Jacobowitz [this message]
2007-12-12 16:26           ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071211175423.GA8014@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=mark.kettenis@xs4all.nl \
    --cc=msnyder@specifix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox