From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16727 invoked by alias); 11 Dec 2007 17:54:39 -0000 Received: (qmail 16717 invoked by uid 22791); 11 Dec 2007 17:54:38 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 11 Dec 2007 17:54:27 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7861198020; Tue, 11 Dec 2007 17:54:25 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 411869801F; Tue, 11 Dec 2007 17:54:25 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1J29JH-00025r-F0; Tue, 11 Dec 2007 12:54:23 -0500 Date: Tue, 11 Dec 2007 18:38:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: Michael Snyder , Mark Kettenis , gdb-patches@sourceware.org Subject: Re: [patch] fileio.exp FAILs if run as root Message-ID: <20071211175423.GA8014@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , Michael Snyder , Mark Kettenis , gdb-patches@sourceware.org References: <20071208181422.GA10275@host0.dyn.jankratochvil.net> <200712081858.lB8Iw5pn014666@brahms.sibelius.xs4all.nl> <20071208191320.GA11395@host0.dyn.jankratochvil.net> <1197393212.32169.63.camel@localhost.localdomain> <20071211174626.GA15092@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071211174626.GA15092@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00162.txt.bz2 On Tue, Dec 11, 2007 at 06:46:26PM +0100, Jan Kratochvil wrote: > There are various warnings around, at least I see now on the console > WARNING: Couldn't find the global config file. > > but apparently nobody cares (do you also see this warning?). I had to start It comes from DejaGNU. There's nothing much we can do about it; set DEJAGNU in your environment to point to a local site.exp, and it will go away. > There are multiple possibilities: > > (1) Keeping there setuid() before somebody complains it does not work. > http://sources.redhat.com/ml/gdb-patches/2007-12/msg00135.html > > (2) Pointing me/anyone at the system where this setuid() code does not work. It will not work on any of the systems the testcase was designed for, i.e. those which use the remote File I/O protocol for file operations. > (3) Skipping (not FAILing) the two tests known they FAIL on the 'root' run. > > (4) Disabling running the testsuite as 'root'. > > (5) Giving just a warning during the start. > > (6) I am too dumb to become a GDB user. > > more? Just ignoring the two failures if you need to run as root for some reason, or xfailing them locally, IMO. I think a warning is quite sufficient. Perhaps in the FAIL message. -- Daniel Jacobowitz CodeSourcery