From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org, Pierre Muller <muller@ics.u-strasbg.fr>
Subject: Re: [RFA 2] gdb/win32-nat.c: do not call CloseHandle on process and thread handles
Date: Sun, 02 Dec 2007 05:46:00 -0000 [thread overview]
Message-ID: <20071202054606.GA7616@ednor.casa.cgf.cx> (raw)
In-Reply-To: <000101c8300d$c1c85960$45590c20$@u-strasbg.fr>
On Mon, Nov 26, 2007 at 10:21:42AM +0100, Pierre Muller wrote:
>2007-11-26 Pierre Muller <muller@ics.u-strasbg.fr>
>
> *win32-nat.c (open_process_used): New static variable.
> (win32_init_thread_list): Remove call to CloseHandle for thread.
> (win32_delete_thread): Ditto.
> (fake_create_process): Set open_process_used if OpenProcess call
> is successful.
> (get_win32_debug_event): Do not close process handle.
> (do_initial_win32_stuff): Set open_process_used to zero.
> (win32_mourn_inferior): Call CloseHandle for current_process_handle
> if open_process_used is set.
> (win32_kill_inferior): Do not close process and main_thread handles.
Approved and applied.
Sorry for the delay. My cygwin build script for gdb is showing its age
and need some kicking with steel-toed shoes.
cgf
next prev parent reply other threads:[~2007-12-02 5:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-22 12:49 [RFA] " Pierre Muller
2007-11-22 12:56 ` Pedro Alves
2007-11-22 13:56 ` Pierre Muller
2007-11-22 14:37 ` Pedro Alves
2007-11-23 1:18 ` Christopher Faylor
2007-11-23 16:21 ` Pierre Muller
2007-11-24 5:44 ` Christopher Faylor
2007-11-26 9:21 ` [RFA 2] " Pierre Muller
2007-12-02 5:46 ` Christopher Faylor [this message]
2007-11-23 16:33 ` [RFA] " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071202054606.GA7616@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=muller@ics.u-strasbg.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox