From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-52509-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1051 invoked by alias); 2 Dec 2007 05:46:12 -0000
Received: (qmail 1041 invoked by uid 22791); 2 Dec 2007 05:46:12 -0000
X-Spam-Check-By: sourceware.org
Received: from pool-70-20-17-24.bstnma.fios.verizon.net (HELO ednor.cgf.cx) (70.20.17.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 02 Dec 2007 05:46:08 +0000
Received: by ednor.cgf.cx (Postfix, from userid 201) 	id 671F62B352; Sun,  2 Dec 2007 00:46:06 -0500 (EST)
Date: Sun, 02 Dec 2007 05:46:00 -0000
From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org, Pierre Muller <muller@ics.u-strasbg.fr>
Subject: Re: [RFA 2] gdb/win32-nat.c: do not call CloseHandle on process 	and  thread handles
Message-ID: <20071202054606.GA7616@ednor.casa.cgf.cx>
Mail-Followup-To: gdb-patches@sourceware.org, 	Pierre Muller <muller@ics.u-strasbg.fr>
References: <002801c82d06$21bdf510$6539df30$@u-strasbg.fr> <4053daab0711220456q46cca9b4m3714c35bcc805518@mail.gmail.com> <002c01c82d0f$8c789050$a569b0f0$@u-strasbg.fr> <4053daab0711220637h2bc01450ra45a19f4013fd44d@mail.gmail.com> <20071123011754.GB31180@ednor.casa.cgf.cx> <006201c82dec$de431850$9ac948f0$@u-strasbg.fr> <20071124054405.GB4214@ednor.casa.cgf.cx> <000101c8300d$c1c85960$45590c20$@u-strasbg.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000101c8300d$c1c85960$45590c20$@u-strasbg.fr>
User-Agent: Mutt/1.5.16 (2007-06-09)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-12/txt/msg00031.txt.bz2

On Mon, Nov 26, 2007 at 10:21:42AM +0100, Pierre Muller wrote:
>2007-11-26  Pierre Muller  <muller@ics.u-strasbg.fr>
>
>	*win32-nat.c (open_process_used): New static variable.
>	(win32_init_thread_list): Remove call to CloseHandle for thread.
>	(win32_delete_thread): Ditto.
>	(fake_create_process): Set open_process_used if OpenProcess call
>	is successful.
>	(get_win32_debug_event): Do not close process handle.
>	(do_initial_win32_stuff): Set open_process_used to zero.
>	(win32_mourn_inferior): Call CloseHandle for current_process_handle
>	if open_process_used is set.
>	(win32_kill_inferior): Do not close process and main_thread handles.

Approved and applied.

Sorry for the delay.  My cygwin build script for gdb is showing its age
and need some kicking with steel-toed shoes.

cgf