From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Remove unused breakpoint fields.
Date: Tue, 20 Nov 2007 08:21:00 -0000 [thread overview]
Message-ID: <200711201121.06299.vladimir@codesourcery.com> (raw)
Some fields of struct breakpoint are no longer used
for anything. Is the below OK?
- Volodya
* breakpoint.h (struct breakpoint): Remove
from_tty and flag fields.
* breakpoint.c (break_command_1): Don't set
from_tty and flag field set of breakpoint.
(create_ada_exception_breakpoint): Don't set
the from_tty field.
---
gdb/breakpoint.c | 3 ---
gdb/breakpoint.h | 8 --------
2 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c
index e81ec20..453e121 100644
--- a/gdb/breakpoint.c
+++ b/gdb/breakpoint.c
@@ -5589,8 +5589,6 @@ break_command_1 (char *arg, int flag, int from_tty)
b->cond_string = cond_string;
b->ignore_count = ignore_count;
b->disposition = tempflag ? disp_del : disp_donttouch;
- b->from_tty = from_tty;
- b->flag = flag;
b->condition_not_parsed = 1;
mention (b);
}
@@ -6696,7 +6694,6 @@ create_ada_exception_breakpoint (struct symtab_and_line sal,
b->exp_string = exp_string;
b->thread = -1;
b->ops = ops;
- b->from_tty = from_tty;
mention (b);
}
diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h
index f13d41b..e4aa72a 100644
--- a/gdb/breakpoint.h
+++ b/gdb/breakpoint.h
@@ -445,14 +445,6 @@ struct breakpoint
/* Methods associated with this breakpoint. */
struct breakpoint_ops *ops;
- /* Was breakpoint issued from a tty? Saved for the use of pending breakpoints. */
- int from_tty;
-
- /* Flag value for pending breakpoint.
- first bit : 0 non-temporary, 1 temporary.
- second bit : 0 normal breakpoint, 1 hardware breakpoint. */
- int flag;
-
/* Is breakpoint's condition not yet parsed because we found
no location initially so had no context to parse
the condition in. */
--
1.5.3.5
next reply other threads:[~2007-11-20 8:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 8:21 Vladimir Prus [this message]
2007-11-20 13:26 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711201121.06299.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox