From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25691 invoked by alias); 20 Nov 2007 08:21:15 -0000 Received: (qmail 25680 invoked by uid 22791); 20 Nov 2007 08:21:14 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 20 Nov 2007 08:21:12 +0000 Received: (qmail 18413 invoked from network); 20 Nov 2007 08:21:10 -0000 Received: from unknown (HELO wind.local) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 20 Nov 2007 08:21:10 -0000 From: Vladimir Prus Date: Tue, 20 Nov 2007 08:21:00 -0000 Subject: [RFA] Remove unused breakpoint fields. To: gdb-patches@sources.redhat.com X-TUID: 56e67aad4f7b7d0a X-Length: 2022 X-UID: 46 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711201121.06299.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00374.txt.bz2 Some fields of struct breakpoint are no longer used for anything. Is the below OK? - Volodya * breakpoint.h (struct breakpoint): Remove from_tty and flag fields. * breakpoint.c (break_command_1): Don't set from_tty and flag field set of breakpoint. (create_ada_exception_breakpoint): Don't set the from_tty field. --- gdb/breakpoint.c | 3 --- gdb/breakpoint.h | 8 -------- 2 files changed, 0 insertions(+), 11 deletions(-) diff --git a/gdb/breakpoint.c b/gdb/breakpoint.c index e81ec20..453e121 100644 --- a/gdb/breakpoint.c +++ b/gdb/breakpoint.c @@ -5589,8 +5589,6 @@ break_command_1 (char *arg, int flag, int from_tty) b->cond_string = cond_string; b->ignore_count = ignore_count; b->disposition = tempflag ? disp_del : disp_donttouch; - b->from_tty = from_tty; - b->flag = flag; b->condition_not_parsed = 1; mention (b); } @@ -6696,7 +6694,6 @@ create_ada_exception_breakpoint (struct symtab_and_line sal, b->exp_string = exp_string; b->thread = -1; b->ops = ops; - b->from_tty = from_tty; mention (b); } diff --git a/gdb/breakpoint.h b/gdb/breakpoint.h index f13d41b..e4aa72a 100644 --- a/gdb/breakpoint.h +++ b/gdb/breakpoint.h @@ -445,14 +445,6 @@ struct breakpoint /* Methods associated with this breakpoint. */ struct breakpoint_ops *ops; - /* Was breakpoint issued from a tty? Saved for the use of pending breakpoints. */ - int from_tty; - - /* Flag value for pending breakpoint. - first bit : 0 non-temporary, 1 temporary. - second bit : 0 normal breakpoint, 1 hardware breakpoint. */ - int flag; - /* Is breakpoint's condition not yet parsed because we found no location initially so had no context to parse the condition in. */ -- 1.5.3.5