From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: deuling@de.ibm.com (Markus Deuling)
Cc: gdb-patches@sourceware.org (GDB Patches)
Subject: Re: [rfc] [03/05] Get rid of current_gdbarch in register_sim_regno
Date: Fri, 16 Nov 2007 18:44:00 -0000 [thread overview]
Message-ID: <200711161844.lAGIi803003296@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <473D4040.5010101@de.ibm.com> from "Markus Deuling" at Nov 16, 2007 08:01:20 AM
Markus Deuling wrote:
> Ok, finished. I dont see a caller of this routine. Is it still needed anywhere or could it
> be deleted? If not, than this is the patch. Ok ?
See Andrew's note (last sentence):
/* NOTE: cagney/2002-05-13: The old code did it this way and it is
suspected that some GDB/SIM combinations may rely on this
behavour. The default should be one2one_register_sim_regno
(below). */
The one2one_register_sim_regno function is already prepared as the
routine that *should* be used where possible, even though it is
not yet used anywhere ... I think we should keep it for now.
> * gdbarch.sh (register_sim_regno): Add gdbarch as parameter.
> * gdbarch.{c,h}: Regenerate.
>
> * arch-utils.h (legacy_register_sim_regno): Add gdbarch as parameter.
> * score-tdep.c (score_register_sim_regno): Likewise.
> * sim-regno.h (one2one_register_sim_regno): Likewise.
>
> * arch-utils.c (legacy_register_sim_regno): Add gdbarch as parameter.
> Replace current_gdbarch by gdbarch.
> * sh-tdep.c (sh_sh2a_register_sim_regno)
> (sh_dsp_register_sim_regno): Likewise.
> * rs6000-tdep.c (rs6000_register_sim_regno): Likewise.
> * mips-tdep.c (mips_register_sim_regno): Likewise.
> * m32c-tdep.c (m32c_register_sim_regno): Likewise.
> * frv-tdep.c (frv_register_sim_regno): Likewise.
> * arm-tdep.c (arm_register_sim_regno): Likewise.
> * remote-sim.c (one2one_register_sim_regno): Likewise.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2007-11-16 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 11:13 Markus Deuling
2007-11-08 21:37 ` Ulrich Weigand
2007-11-14 8:39 ` Markus Deuling
2007-11-15 14:10 ` Ulrich Weigand
2007-11-16 7:03 ` Markus Deuling
2007-11-16 18:44 ` Ulrich Weigand [this message]
2007-11-19 5:07 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711161844.lAGIi803003296@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox