From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20998 invoked by alias); 16 Nov 2007 18:44:15 -0000 Received: (qmail 20985 invoked by uid 22791); 16 Nov 2007 18:44:14 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate6.de.ibm.com (HELO mtagate6.de.ibm.com) (195.212.29.155) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 16 Nov 2007 18:44:12 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate6.de.ibm.com (8.13.8/8.13.8) with ESMTP id lAGIi9BS205630 for ; Fri, 16 Nov 2007 18:44:09 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.6) with ESMTP id lAGIi9d82715808 for ; Fri, 16 Nov 2007 19:44:09 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lAGIi8RR003299 for ; Fri, 16 Nov 2007 19:44:08 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id lAGIi803003296; Fri, 16 Nov 2007 19:44:08 +0100 Message-Id: <200711161844.lAGIi803003296@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Fri, 16 Nov 2007 19:44:08 +0100 Subject: Re: [rfc] [03/05] Get rid of current_gdbarch in register_sim_regno To: deuling@de.ibm.com (Markus Deuling) Date: Fri, 16 Nov 2007 18:44:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <473D4040.5010101@de.ibm.com> from "Markus Deuling" at Nov 16, 2007 08:01:20 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00340.txt.bz2 Markus Deuling wrote: > Ok, finished. I dont see a caller of this routine. Is it still needed anywhere or could it > be deleted? If not, than this is the patch. Ok ? See Andrew's note (last sentence): /* NOTE: cagney/2002-05-13: The old code did it this way and it is suspected that some GDB/SIM combinations may rely on this behavour. The default should be one2one_register_sim_regno (below). */ The one2one_register_sim_regno function is already prepared as the routine that *should* be used where possible, even though it is not yet used anywhere ... I think we should keep it for now. > * gdbarch.sh (register_sim_regno): Add gdbarch as parameter. > * gdbarch.{c,h}: Regenerate. > > * arch-utils.h (legacy_register_sim_regno): Add gdbarch as parameter. > * score-tdep.c (score_register_sim_regno): Likewise. > * sim-regno.h (one2one_register_sim_regno): Likewise. > > * arch-utils.c (legacy_register_sim_regno): Add gdbarch as parameter. > Replace current_gdbarch by gdbarch. > * sh-tdep.c (sh_sh2a_register_sim_regno) > (sh_dsp_register_sim_regno): Likewise. > * rs6000-tdep.c (rs6000_register_sim_regno): Likewise. > * mips-tdep.c (mips_register_sim_regno): Likewise. > * m32c-tdep.c (m32c_register_sim_regno): Likewise. > * frv-tdep.c (frv_register_sim_regno): Likewise. > * arm-tdep.c (arm_register_sim_regno): Likewise. > * remote-sim.c (one2one_register_sim_regno): Likewise. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com