From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] new setting to not-print frame arguments values
Date: Fri, 09 Nov 2007 19:09:00 -0000 [thread overview]
Message-ID: <20071109190652.GA4339@adacore.com> (raw)
In-Reply-To: <20071108043830.GA20791@caradoc.them.org>
> > I'm okay with the idea.
>
> Me too. Something looked odd with your indentation in
> print_frame_args, but otherwise the patch looks OK, too.
Thanks everyone for the feedback. The oddness, I believe, comes from
the ($@^$#%) tabs - The extra leading character in the diff sometimes
makes it look odd. However, there was one place at the end of the patch
where I forgot to convert spaces into tabs, so I fixed it.
The patch is now in. Documentation and testcase coming up shortly.
--
Joel
PS: God, I hate tabs...
prev parent reply other threads:[~2007-11-09 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-08 1:19 Joel Brobecker
2007-11-08 4:17 ` Eli Zaretskii
2007-11-08 4:38 ` Daniel Jacobowitz
2007-11-09 19:09 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071109190652.GA4339@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox