From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 860 invoked by alias); 9 Nov 2007 19:09:03 -0000 Received: (qmail 848 invoked by uid 22791); 9 Nov 2007 19:09:02 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 09 Nov 2007 19:09:00 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 56EDA2AA394 for ; Fri, 9 Nov 2007 14:06:55 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id cwo6sR54WwpZ for ; Fri, 9 Nov 2007 14:06:55 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id BDF662AA2FF for ; Fri, 9 Nov 2007 14:06:54 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 62E8CE7ACA; Fri, 9 Nov 2007 11:06:52 -0800 (PST) Date: Fri, 09 Nov 2007 19:09:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFC] new setting to not-print frame arguments values Message-ID: <20071109190652.GA4339@adacore.com> References: <20071108011940.GI3911@adacore.com> <20071108043830.GA20791@caradoc.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071108043830.GA20791@caradoc.them.org> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00203.txt.bz2 > > I'm okay with the idea. > > Me too. Something looked odd with your indentation in > print_frame_args, but otherwise the patch looks OK, too. Thanks everyone for the feedback. The oddness, I believe, comes from the ($@^$#%) tabs - The extra leading character in the diff sometimes makes it look odd. However, there was one place at the end of the patch where I forgot to convert spaces into tabs, so I fixed it. The patch is now in. Documentation and testcase coming up shortly. -- Joel PS: God, I hate tabs...