Re: gdbserver pipe, xml and monitor changes

[Daniel Jacobowitz <drow@false.org>]

I'm always happy to see gdbserver contributions!

On Tue, Nov 06, 2007 at 01:15:26PM +1100, Chris Johns wrote:
> This patch adds support for the GDB remote pipe, plus new handlers so the 
> back-end can handle XML files and add custom monitor commands. I have used the 
> gdbserver code to implement a remote server for the Coldfire BDM interface.
> 
> The XML back-end handler allows the back-end to detect the type of processor 
> and then provide the suitable XML file.
> 
> I have also added support to detect if a register in the cache is dirty when 
> collected by the back-end.
> 
> The 'z' and 'Z' watchpoint type filtering now allows type 1 through to the 
> back-end. I checked the current back-ends in the gdbserver code and where not 
> effected.
> 
> I have run make check but I could not see a gdbserver test run. Is there one ?

Take a look at the gdb Wiki; there's a page describing how to run the
testsuite against a local gdbserver.

First of all, do you have a copyright assignment?  This is too big to
take without one.  I see something that looks like you in the
copyright assignment list, but the associated employer disclaimer is
expired.

After that's taken care of, I'd really appreciate it if you could
break this up into a couple of logical pieces.  It makes them a lot
easier to look at.  For instance, the register shadow cache is
independent of everything else.

The pipe changes are user-visible, so we should update the manual.  I
can take care of that later.

> The various low level back-ends have not be changed to printf_filtered or 
> warning. Should they ?

Yes, if we document that pipe is available for them.

-- 
Daniel Jacobowitz
CodeSourcery