From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9459 invoked by alias); 6 Nov 2007 03:34:17 -0000 Received: (qmail 9449 invoked by uid 22791); 6 Nov 2007 03:34:16 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 06 Nov 2007 03:34:13 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7CB6D98353; Tue, 6 Nov 2007 03:34:10 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id DEF06981F2; Tue, 6 Nov 2007 03:34:09 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1IpFCa-00051h-Cr; Mon, 05 Nov 2007 22:34:08 -0500 Date: Tue, 06 Nov 2007 03:34:00 -0000 From: Daniel Jacobowitz To: Chris Johns Cc: gdb-patches@sourceware.org Subject: Re: gdbserver pipe, xml and monitor changes Message-ID: <20071106033408.GA18729@caradoc.them.org> Mail-Followup-To: Chris Johns , gdb-patches@sourceware.org References: <472FCE3E.8000508@rtems.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <472FCE3E.8000508@rtems.org> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00089.txt.bz2 I'm always happy to see gdbserver contributions! On Tue, Nov 06, 2007 at 01:15:26PM +1100, Chris Johns wrote: > This patch adds support for the GDB remote pipe, plus new handlers so the > back-end can handle XML files and add custom monitor commands. I have used the > gdbserver code to implement a remote server for the Coldfire BDM interface. > > The XML back-end handler allows the back-end to detect the type of processor > and then provide the suitable XML file. > > I have also added support to detect if a register in the cache is dirty when > collected by the back-end. > > The 'z' and 'Z' watchpoint type filtering now allows type 1 through to the > back-end. I checked the current back-ends in the gdbserver code and where not > effected. > > I have run make check but I could not see a gdbserver test run. Is there one ? Take a look at the gdb Wiki; there's a page describing how to run the testsuite against a local gdbserver. First of all, do you have a copyright assignment? This is too big to take without one. I see something that looks like you in the copyright assignment list, but the associated employer disclaimer is expired. After that's taken care of, I'd really appreciate it if you could break this up into a couple of logical pieces. It makes them a lot easier to look at. For instance, the register shadow cache is independent of everything else. The pipe changes are user-visible, so we should update the manual. I can take care of that later. > The various low level back-ends have not be changed to printf_filtered or > warning. Should they ? Yes, if we document that pipe is available for them. -- Daniel Jacobowitz CodeSourcery