From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: deuling@de.ibm.com (Markus Deuling)
Cc: gdb-patches@sourceware.org (GDB Patches)
Subject: Re: [rfc] [09/09] Get rid of current_gdbarch (gdbarch parameter to legacy_virtual_frame_pointer)
Date: Mon, 05 Nov 2007 16:08:00 -0000 [thread overview]
Message-ID: <200711051608.lA5G8aga018266@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <472F0AD7.1000508@de.ibm.com> from "Markus Deuling" at Nov 05, 2007 01:21:43 PM
Markus Deuling wrote:
> this patchs adds gdbarch parameter to legacy_virtual_frame_pointer and updates its
> sole implementation in arch-utils.
Huh? There are three further instances of gdbarch_virtual_frame_pointer
(in m32c-tdep.c, mips-tdep.c, spu-tdep.c). The patch as-is would break
those platforms ...
I guess if those are fixed it would be OK to convert the function for now;
however, in the long run, the virtual_frame_pointer function needs to be
eliminated -- the tracepoint framework should really be getting this data
from the debug information.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2007-11-05 16:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 12:23 Markus Deuling
2007-11-05 16:08 ` Ulrich Weigand [this message]
2007-11-06 12:03 ` Markus Deuling
2007-11-06 17:46 ` Ulrich Weigand
2007-11-07 7:00 ` Markus Deuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711051608.lA5G8aga018266@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=deuling@de.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox