From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29063 invoked by alias); 5 Nov 2007 16:08:42 -0000 Received: (qmail 29055 invoked by uid 22791); 5 Nov 2007 16:08:41 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate3.de.ibm.com (HELO mtagate3.de.ibm.com) (195.212.29.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Nov 2007 16:08:40 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate3.de.ibm.com (8.13.8/8.13.8) with ESMTP id lA5G8bmc193810 for ; Mon, 5 Nov 2007 16:08:37 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id lA5G8a832138158 for ; Mon, 5 Nov 2007 17:08:37 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lA5G8aZP018269 for ; Mon, 5 Nov 2007 17:08:36 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id lA5G8aga018266; Mon, 5 Nov 2007 17:08:36 +0100 Message-Id: <200711051608.lA5G8aga018266@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 5 Nov 2007 17:08:36 +0100 Subject: Re: [rfc] [09/09] Get rid of current_gdbarch (gdbarch parameter to legacy_virtual_frame_pointer) To: deuling@de.ibm.com (Markus Deuling) Date: Mon, 05 Nov 2007 16:08:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org (GDB Patches) In-Reply-To: <472F0AD7.1000508@de.ibm.com> from "Markus Deuling" at Nov 05, 2007 01:21:43 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00069.txt.bz2 Markus Deuling wrote: > this patchs adds gdbarch parameter to legacy_virtual_frame_pointer and updates its > sole implementation in arch-utils. Huh? There are three further instances of gdbarch_virtual_frame_pointer (in m32c-tdep.c, mips-tdep.c, spu-tdep.c). The patch as-is would break those platforms ... I guess if those are fixed it would be OK to convert the function for now; however, in the long run, the virtual_frame_pointer function needs to be eliminated -- the tracepoint framework should really be getting this data from the debug information. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com