Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: deuling@de.ibm.com
Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com
Subject: Re: [rfc]: Macros in gdbtypes
Date: Mon, 05 Nov 2007 14:15:00 -0000	[thread overview]
Message-ID: <200711051415.lA5EFmvm024502@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <472F0BF2.9010801@de.ibm.com> (message from Markus Deuling on 	Mon, 05 Nov 2007 13:26:26 +0100)

> Date: Mon, 05 Nov 2007 13:26:26 +0100
> From: Markus Deuling <deuling@de.ibm.com>
> 
> Hi,
> 
> in gdbtypes.h are some macros based on current_gdbarch (eg. builtin_type_void_data_ptr). This patch
> replaces builtin_type_void_data_ptr by its definition in the source tree and then replaces current_gdbarch
> by appropriate methods were possible.
> 
> This patch is **NOT** tested and shall no be committed right now. 
> 
> Before proceeding I want to hear from you if that's a way to go for those macros or if you would prefer s.th. else to get rid
> of the current_gdbarch's in gdbtypes.h

Please no!  I think it obfuscates the code to much.  It's probably
better to change builtin_type_void_data_ptr to take a gdbarch
argument.


  reply	other threads:[~2007-11-05 14:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-05 12:28 Markus Deuling
2007-11-05 14:15 ` Mark Kettenis [this message]
2007-11-05 15:18 ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200711051415.lA5EFmvm024502@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=deuling@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox