From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: [rfc] [04/09] Get rid of current_gdbarch (SIZEOF_FRAME_SAVED_REGS macro)
Date: Mon, 05 Nov 2007 14:00:00 -0000 [thread overview]
Message-ID: <20071105140039.GA30087@caradoc.them.org> (raw)
In-Reply-To: <200711051343.lA5DhTWq006451@brahms.sibelius.xs4all.nl>
On Mon, Nov 05, 2007 at 02:43:29PM +0100, Mark Kettenis wrote:
> > Date: Mon, 05 Nov 2007 13:21:29 +0100
> > From: Markus Deuling <deuling@de.ibm.com>
> >
> > Hi,
> >
> > this patch replaces SIZEOF_FRAME_SAVED_REGS macro by its expression.
> >
> > Tested by gdb_mbuild with alpha target. Is this ok to commit?
>
> I'm not thrilled, since this replaces a #define that has a sensible
> name with some sort of complicated expression, and therefore makes the
> code much more difficult to read.
Ditto. frame_zalloc_saved_regs (frame)?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-11-05 14:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 12:23 Markus Deuling
2007-11-05 13:44 ` Mark Kettenis
2007-11-05 14:00 ` Daniel Jacobowitz [this message]
2007-11-05 15:14 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071105140039.GA30087@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox