From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31106 invoked by alias); 5 Nov 2007 14:00:48 -0000 Received: (qmail 31098 invoked by uid 22791); 5 Nov 2007 14:00:48 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 05 Nov 2007 14:00:43 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 529B998353 for ; Mon, 5 Nov 2007 14:00:41 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id B43D9981F2 for ; Mon, 5 Nov 2007 14:00:40 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1Ip2VL-0007uG-Sl for gdb-patches@sourceware.org; Mon, 05 Nov 2007 09:00:39 -0500 Date: Mon, 05 Nov 2007 14:00:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: [rfc] [04/09] Get rid of current_gdbarch (SIZEOF_FRAME_SAVED_REGS macro) Message-ID: <20071105140039.GA30087@caradoc.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <472F0AC9.7030700@de.ibm.com> <200711051343.lA5DhTWq006451@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200711051343.lA5DhTWq006451@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00058.txt.bz2 On Mon, Nov 05, 2007 at 02:43:29PM +0100, Mark Kettenis wrote: > > Date: Mon, 05 Nov 2007 13:21:29 +0100 > > From: Markus Deuling > > > > Hi, > > > > this patch replaces SIZEOF_FRAME_SAVED_REGS macro by its expression. > > > > Tested by gdb_mbuild with alpha target. Is this ok to commit? > > I'm not thrilled, since this replaces a #define that has a sensible > name with some sort of complicated expression, and therefore makes the > code much more difficult to read. Ditto. frame_zalloc_saved_regs (frame)? -- Daniel Jacobowitz CodeSourcery