From: Daniel Jacobowitz <drow@false.org>
To: Luis Machado <luisgpm@linux.vnet.ibm.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] printf support for DFP values
Date: Thu, 01 Nov 2007 15:34:00 -0000 [thread overview]
Message-ID: <20071101153418.GA19992@caradoc.them.org> (raw)
In-Reply-To: <1193879919.4994.2.camel@localhost>
Your most recent message was missing the revised patch, so I'm
replying to an older one. I was going to complain aobut some debug
printfs, but you seem to have fixed them already.
On Wed, Oct 31, 2007 at 10:18:39PM -0300, Luis Machado wrote:
> +#if defined (PRINTF_HAS_DECFLOAT)
> + printf_filtered(current_substring, dfp_value_ptr);
> +#else
Here and a couple of other places in the patch, please remember the
space before a left parenthesis.
> +AC_CACHE_CHECK([for decfloat support in printf],
> + gdb_cv_printf_has_decfloat,
> + [AC_RUN_IFELSE([AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT],
Boo, more run checks in configure :-( I cross-compile most of my
GDBs so run checks do not work. Well, this is not a new problem.
Rest looks fine to me too.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-11-01 15:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-27 6:25 Luis Machado
2007-10-27 12:05 ` Eli Zaretskii
2007-10-29 15:03 ` Luis Machado
2007-10-29 20:12 ` Eli Zaretskii
2007-10-29 20:19 ` Daniel Jacobowitz
2007-10-30 4:20 ` Eli Zaretskii
2007-10-30 4:39 ` Eli Zaretskii
2007-10-30 18:19 ` Luis Machado
2007-10-30 20:58 ` Eli Zaretskii
2007-11-01 1:18 ` Luis Machado
2007-11-01 4:11 ` Eli Zaretskii
2007-11-01 10:21 ` Andreas Schwab
2007-11-01 12:02 ` Luis Machado
2007-11-02 12:05 ` Eli Zaretskii
2007-11-01 15:34 ` Daniel Jacobowitz [this message]
2007-11-01 16:00 ` Luis Machado
2007-11-02 12:07 ` Eli Zaretskii
2007-11-05 11:35 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071101153418.GA19992@caradoc.them.org \
--to=drow@false.org \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox