From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5043 invoked by alias); 1 Nov 2007 15:34:29 -0000 Received: (qmail 5026 invoked by uid 22791); 1 Nov 2007 15:34:28 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 01 Nov 2007 15:34:22 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 0BE6298103; Thu, 1 Nov 2007 15:34:20 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id C1393980A7; Thu, 1 Nov 2007 15:34:19 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.68) (envelope-from ) id 1Inc3m-0005HQ-Kl; Thu, 01 Nov 2007 11:34:18 -0400 Date: Thu, 01 Nov 2007 15:34:00 -0000 From: Daniel Jacobowitz To: Luis Machado Cc: Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH] printf support for DFP values Message-ID: <20071101153418.GA19992@caradoc.them.org> Mail-Followup-To: Luis Machado , Eli Zaretskii , gdb-patches@sourceware.org References: <1193449497.6950.22.camel@localhost> <1193669215.4800.10.camel@localhost> <20071029201252.GA21583@caradoc.them.org> <1193753649.4283.5.camel@localhost> <1193879919.4994.2.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1193879919.4994.2.camel@localhost> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-11/txt/msg00010.txt.bz2 Your most recent message was missing the revised patch, so I'm replying to an older one. I was going to complain aobut some debug printfs, but you seem to have fixed them already. On Wed, Oct 31, 2007 at 10:18:39PM -0300, Luis Machado wrote: > +#if defined (PRINTF_HAS_DECFLOAT) > + printf_filtered(current_substring, dfp_value_ptr); > +#else Here and a couple of other places in the patch, please remember the space before a left parenthesis. > +AC_CACHE_CHECK([for decfloat support in printf], > + gdb_cv_printf_has_decfloat, > + [AC_RUN_IFELSE([AC_LANG_PROGRAM([AC_INCLUDES_DEFAULT], Boo, more run checks in configure :-( I cross-compile most of my GDBs so run checks do not work. Well, this is not a new problem. Rest looks fine to me too. -- Daniel Jacobowitz CodeSourcery