From: Joel Brobecker <brobecker@adacore.com>
To: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
Cc: Jim Blandy <jimb@codesourcery.com>,
gdb@sourceware.org,
GDB Patches Mailing List <gdb-patches@sourceware.org>,
drow@false.org
Subject: Re: Problems while debugging fortran
Date: Thu, 25 Oct 2007 20:55:00 -0000 [thread overview]
Message-ID: <20071025204134.GC4157@adacore.com> (raw)
In-Reply-To: <4720FE48.8020200@linux.vnet.ibm.com>
> 2007-10-25 Wu Zhou <woodzltc@cn.ibm.com>
> Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
> Jim Blandy <jimb@codesourcery.com>
>
> * dwarf2read.c (read_partial_die): check the value
> of DW_AT_calling_convention in Fortran programs.
Just one minor comment:
> + if ((DW_UNSND (&attr) == DW_CC_program) && (cu->language == language_fortran))
Could you remove the unnecessary extra parens and split this line
into two (it's too long):
if (DW_UNSND (&attr) == DW_CC_program
&& cu->language == language_fortran)
Your patch is approved with that adjustment.
Thanks,
--
Joel
next prev parent reply other threads:[~2007-10-25 20:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19c433eb0710250906k392cecf8t1f99595d5c5a8107@mail.gmail.com>
[not found] ` <20071025170621.GA27275@caradoc.them.org>
[not found] ` <m3lk9rxceq.fsf@codesourcery.com>
[not found] ` <20071025190150.GA1560@caradoc.them.org>
[not found] ` <m3tzof9eqq.fsf@codesourcery.com>
[not found] ` <20071025202406.GC4063@adacore.com>
2007-10-25 20:41 ` Carlos Eduardo Seo
2007-10-25 20:55 ` Joel Brobecker [this message]
2007-10-25 21:47 ` Carlos Eduardo Seo
2007-10-25 20:57 ` Andreas Schwab
[not found] <46F2CE45.5020308@linux.vnet.ibm.com>
[not found] ` <20070920204622.GB4368@adacore.com>
[not found] ` <20070920205629.GA17779@caradoc.them.org>
[not found] ` <46FAD136.5030406@linux.vnet.ibm.com>
[not found] ` <20070926214619.GC9403@adacore.com>
[not found] ` <471F70C0.3000206@linux.vnet.ibm.com>
[not found] ` <20071024193336.GI11797@adacore.com>
[not found] ` <20071024195719.GA16009@caradoc.them.org>
[not found] ` <471FA810.6080506@linux.vnet.ibm.com>
[not found] ` <471FBF9E.5000607@linux.vnet.ibm.com>
2007-10-24 22:14 ` Joel Brobecker
2007-10-25 14:10 ` Carlos Eduardo Seo
2007-10-25 15:41 ` Jim Blandy
2007-10-25 16:15 ` Daniel Jacobowitz
2007-10-25 16:18 ` Carlos Eduardo Seo
2007-10-25 17:05 ` Jim Blandy
2007-10-25 18:19 ` Daniel Jacobowitz
2007-10-25 19:05 ` Jim Blandy
2007-10-25 19:23 ` Joel Brobecker
2007-10-25 19:10 ` Joel Brobecker
2007-10-25 19:35 ` Jim Blandy
2007-10-25 20:00 ` Daniel Jacobowitz
2007-10-25 20:32 ` Carlos Eduardo Seo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025204134.GC4157@adacore.com \
--to=brobecker@adacore.com \
--cc=cseo@linux.vnet.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox