From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-51699-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5727 invoked by alias); 25 Oct 2007 20:41:45 -0000
Received: (qmail 5708 invoked by uid 22791); 25 Oct 2007 20:41:44 -0000
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 25 Oct 2007 20:41:38 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id DD6B42AB436; 	Thu, 25 Oct 2007 16:41:36 -0400 (EDT)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id 5QfstRogcV6k; Thu, 25 Oct 2007 16:41:36 -0400 (EDT)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id A3DBF2AAB55; 	Thu, 25 Oct 2007 16:41:36 -0400 (EDT)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id 8CF49E7AC8; Thu, 25 Oct 2007 13:41:34 -0700 (PDT)
Date: Thu, 25 Oct 2007 20:55:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Carlos Eduardo Seo <cseo@linux.vnet.ibm.com>
Cc: Jim Blandy <jimb@codesourcery.com>, gdb@sourceware.org, 	GDB Patches Mailing List <gdb-patches@sourceware.org>, 	drow@false.org
Subject: Re: Problems while debugging fortran
Message-ID: <20071025204134.GC4157@adacore.com>
References: <19c433eb0710250906k392cecf8t1f99595d5c5a8107@mail.gmail.com> <20071025170621.GA27275@caradoc.them.org> <m3lk9rxceq.fsf@codesourcery.com> <20071025190150.GA1560@caradoc.them.org> <m3tzof9eqq.fsf@codesourcery.com> <20071025202406.GC4063@adacore.com> <4720FE48.8020200@linux.vnet.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4720FE48.8020200@linux.vnet.ibm.com>
User-Agent: Mutt/1.4.2.2i
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-10/txt/msg00677.txt.bz2

> 2007-10-25  Wu Zhou  <woodzltc@cn.ibm.com>
> 	    Carlos Eduardo Seo  <cseo@linux.vnet.ibm.com>
> 	    Jim Blandy  <jimb@codesourcery.com>
> 
> 	* dwarf2read.c (read_partial_die): check the value
> 	of DW_AT_calling_convention in Fortran programs.

Just one minor comment:

> +	  if ((DW_UNSND (&attr) == DW_CC_program) && (cu->language == language_fortran))

Could you remove the unnecessary extra parens and split this line
into two (it's too long):

        if (DW_UNSND (&attr) == DW_CC_program
            && cu->language == language_fortran)

Your patch is approved with that adjustment.

Thanks,
-- 
Joel