From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFC] m32r-tdep.c: Fix sign extension problem during prologue analysis
Date: Tue, 16 Oct 2007 07:53:00 -0000 [thread overview]
Message-ID: <20071015234038.29fe69f4@ironwood.lan> (raw)
In-Reply-To: <20071011012950.GA17345@caradoc.them.org>
On Wed, 10 Oct 2007 21:29:50 -0400
Daniel Jacobowitz <drow@false.org> wrote:
> > Comments? (Is there a better way to do the sign extension?)
>
> That seems right to me. You could be more explicit about it, but
> there's no point if you assume that char is eight bits anyway.
Thanks for looking at this patch.
I've committed it now.
Kevin
prev parent reply other threads:[~2007-10-16 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 1:29 Kevin Buettner
2007-10-11 7:26 ` Daniel Jacobowitz
2007-10-16 7:53 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071015234038.29fe69f4@ironwood.lan \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox