From: Daniel Jacobowitz <drow@false.org>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org, sakamoto.kei@renesas.com
Subject: Re: [RFC] m32r-tdep.c: Fix sign extension problem during prologue analysis
Date: Thu, 11 Oct 2007 07:26:00 -0000 [thread overview]
Message-ID: <20071011012950.GA17345@caradoc.them.org> (raw)
In-Reply-To: <20071010170252.65259f1a@ironwood.lan>
On Wed, Oct 10, 2007 at 05:02:52PM -0700, Kevin Buettner wrote:
> I recently learned that there were far too many testsuite failures for
> the m32r-elf target. I found that backtraces (among other things)
> were badly broken and traced the problem to a lack of sign extension
> for a particular instruction pattern during prologue analysis.
>
> Comments? (Is there a better way to do the sign extension?)
That seems right to me. You could be more explicit about it, but
there's no point if you assume that char is eight bits anyway.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-10-11 1:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-11 1:29 Kevin Buettner
2007-10-11 7:26 ` Daniel Jacobowitz [this message]
2007-10-16 7:53 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071011012950.GA17345@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
--cc=sakamoto.kei@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox