Re: [RFA] gdb_ari.sh patch to eliminate wrong critical errors

["Ulrich Weigand" <uweigand@de.ibm.com>]

Pierre Muller wrote:

> 2) GNU/Linux	4	Do not use `Linux', instead use `Linux kernel' 
> or `GNU/Linux system'; comments should clearly differentiate between 
> the two (this test assumes that word `Linux' appears on the same line 
> as the word `GNU' or `kernel'
>   This one is a little too subtle for me, as I am hardly able to
> distinguish between 'GNU/Linux system' and 'Linux kernel'...

I've committed the following patch to fix those instances.  I hope
I got all of them ...

Bye,
Ulrich

ChangeLog:

	* linux-nat.c (lin_lwp_attach_lwp): Use "Linux kernel 2.6.19"
	instead of "Linux 2.6.19" in comment.
	(linux_xfer_partial): Use "GNU/Linux target" instead of 
	"Linux target" in comment.
	* m68klinux-tdep.c (m68k_linux_inferior_created): Likewise.
	(m68k_linux_get_sigtramp_info): Likewise.

Index: gdb/linux-nat.c
===================================================================
RCS file: /cvs/src/src/gdb/linux-nat.c,v
retrieving revision 1.69
diff -c -p -r1.69 linux-nat.c
*** gdb/linux-nat.c	2 Oct 2007 16:33:35 -0000	1.69
--- gdb/linux-nat.c	11 Oct 2007 19:26:38 -0000
*************** lin_lwp_attach_lwp (ptid_t ptid, int ver
*** 902,908 ****
  	{
  	  /* If we fail to attach to the thread, issue a warning,
  	     but continue.  One way this can happen is if thread
! 	     creation is interrupted; as of Linux 2.6.19, a kernel
  	     bug may place threads in the thread list and then fail
  	     to create them.  */
  	  warning (_("Can't attach %s: %s"), target_pid_to_str (ptid),
--- 902,908 ----
  	{
  	  /* If we fail to attach to the thread, issue a warning,
  	     but continue.  One way this can happen is if thread
! 	     creation is interrupted; as of Linux kernel 2.6.19, a
  	     bug may place threads in the thread list and then fail
  	     to create them.  */
  	  warning (_("Can't attach %s: %s"), target_pid_to_str (ptid),
*************** linux_xfer_partial (struct target_ops *o
*** 3212,3218 ****
  			     offset, len);
  }
  
! /* Create a prototype generic Linux target.  The client can override
     it with local methods.  */
  
  static void
--- 3212,3218 ----
  			     offset, len);
  }
  
! /* Create a prototype generic GNU/Linux target.  The client can override
     it with local methods.  */
  
  static void
Index: gdb/m68klinux-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/m68klinux-tdep.c,v
retrieving revision 1.25
diff -c -p -r1.25 m68klinux-tdep.c
*** gdb/m68klinux-tdep.c	8 Oct 2007 12:54:07 -0000	1.25
--- gdb/m68klinux-tdep.c	11 Oct 2007 19:26:38 -0000
*************** static int target_is_uclinux;
*** 213,220 ****
  static void
  m68k_linux_inferior_created (struct target_ops *objfile, int from_tty)
  {
!   /* Record that we will need to re-evaluate whether we are running on
!      a uClinux or normal Linux target (see m68k_linux_get_sigtramp_info).  */
    target_is_uclinux = -1;
  }
  
--- 213,220 ----
  static void
  m68k_linux_inferior_created (struct target_ops *objfile, int from_tty)
  {
!   /* Record that we will need to re-evaluate whether we are running on a
!      uClinux or normal GNU/Linux target (see m68k_linux_get_sigtramp_info).  */
    target_is_uclinux = -1;
  }
  
*************** m68k_linux_get_sigtramp_info (struct fra
*** 227,233 ****
  
    if (target_is_uclinux == -1)
      {
!       /* Determine whether we are running on a uClinux or normal Linux
           target so we can use the correct sigcontext layouts.  */
      
        CORE_ADDR dummy;
--- 227,233 ----
  
    if (target_is_uclinux == -1)
      {
!       /* Determine whether we are running on a uClinux or normal GNU/Linux
           target so we can use the correct sigcontext layouts.  */
      
        CORE_ADDR dummy;


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com