From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10746 invoked by alias); 11 Oct 2007 19:40:06 -0000 Received: (qmail 10734 invoked by uid 22791); 11 Oct 2007 19:40:05 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.29.150) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 11 Oct 2007 19:40:00 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.8/8.13.8) with ESMTP id l9BJdvQa778984 for ; Thu, 11 Oct 2007 19:39:58 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l9BJdvqX2322684 for ; Thu, 11 Oct 2007 21:39:57 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l9BJdv7A025574 for ; Thu, 11 Oct 2007 21:39:57 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id l9BJdvgd025571; Thu, 11 Oct 2007 21:39:57 +0200 Message-Id: <200710111939.l9BJdvgd025571@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 11 Oct 2007 21:39:57 +0200 Subject: Re: [RFA] gdb_ari.sh patch to eliminate wrong critical errors To: muller@ics.u-strasbg.fr (Pierre Muller) Date: Thu, 11 Oct 2007 19:41:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org ('Daniel Jacobowitz'), gdb-patches@sourceware.org In-Reply-To: <000001c80b14$db947450$92bd5cf0$@u-strasbg.fr> from "Pierre Muller" at Oct 10, 2007 10:09:18 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00323.txt.bz2 Pierre Muller wrote: > 2) GNU/Linux 4 Do not use `Linux', instead use `Linux kernel' > or `GNU/Linux system'; comments should clearly differentiate between > the two (this test assumes that word `Linux' appears on the same line > as the word `GNU' or `kernel' > This one is a little too subtle for me, as I am hardly able to > distinguish between 'GNU/Linux system' and 'Linux kernel'... I've committed the following patch to fix those instances. I hope I got all of them ... Bye, Ulrich ChangeLog: * linux-nat.c (lin_lwp_attach_lwp): Use "Linux kernel 2.6.19" instead of "Linux 2.6.19" in comment. (linux_xfer_partial): Use "GNU/Linux target" instead of "Linux target" in comment. * m68klinux-tdep.c (m68k_linux_inferior_created): Likewise. (m68k_linux_get_sigtramp_info): Likewise. Index: gdb/linux-nat.c =================================================================== RCS file: /cvs/src/src/gdb/linux-nat.c,v retrieving revision 1.69 diff -c -p -r1.69 linux-nat.c *** gdb/linux-nat.c 2 Oct 2007 16:33:35 -0000 1.69 --- gdb/linux-nat.c 11 Oct 2007 19:26:38 -0000 *************** lin_lwp_attach_lwp (ptid_t ptid, int ver *** 902,908 **** { /* If we fail to attach to the thread, issue a warning, but continue. One way this can happen is if thread ! creation is interrupted; as of Linux 2.6.19, a kernel bug may place threads in the thread list and then fail to create them. */ warning (_("Can't attach %s: %s"), target_pid_to_str (ptid), --- 902,908 ---- { /* If we fail to attach to the thread, issue a warning, but continue. One way this can happen is if thread ! creation is interrupted; as of Linux kernel 2.6.19, a bug may place threads in the thread list and then fail to create them. */ warning (_("Can't attach %s: %s"), target_pid_to_str (ptid), *************** linux_xfer_partial (struct target_ops *o *** 3212,3218 **** offset, len); } ! /* Create a prototype generic Linux target. The client can override it with local methods. */ static void --- 3212,3218 ---- offset, len); } ! /* Create a prototype generic GNU/Linux target. The client can override it with local methods. */ static void Index: gdb/m68klinux-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/m68klinux-tdep.c,v retrieving revision 1.25 diff -c -p -r1.25 m68klinux-tdep.c *** gdb/m68klinux-tdep.c 8 Oct 2007 12:54:07 -0000 1.25 --- gdb/m68klinux-tdep.c 11 Oct 2007 19:26:38 -0000 *************** static int target_is_uclinux; *** 213,220 **** static void m68k_linux_inferior_created (struct target_ops *objfile, int from_tty) { ! /* Record that we will need to re-evaluate whether we are running on ! a uClinux or normal Linux target (see m68k_linux_get_sigtramp_info). */ target_is_uclinux = -1; } --- 213,220 ---- static void m68k_linux_inferior_created (struct target_ops *objfile, int from_tty) { ! /* Record that we will need to re-evaluate whether we are running on a ! uClinux or normal GNU/Linux target (see m68k_linux_get_sigtramp_info). */ target_is_uclinux = -1; } *************** m68k_linux_get_sigtramp_info (struct fra *** 227,233 **** if (target_is_uclinux == -1) { ! /* Determine whether we are running on a uClinux or normal Linux target so we can use the correct sigcontext layouts. */ CORE_ADDR dummy; --- 227,233 ---- if (target_is_uclinux == -1) { ! /* Determine whether we are running on a uClinux or normal GNU/Linux target so we can use the correct sigcontext layouts. */ CORE_ADDR dummy; -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com