[RFA] top level configure and makeinfo/texinfo

[RFA] top level configure and makeinfo/texinfo

[Michael Snyder]

Texinfo is up to version 4.11, I believe (at least).
When somebody gets around to running gdb's top level
configure with this, it's going to fail due to a 
regular expression that won't recognize a minor 
version number greater than 9.

Not sure who should approve this...

And yes, I realize that there are 3 or 4 other configure
scripts to which this also applies.

2007-10-09  Michael Snyder  <msnyder@specifix.com>

	* configure.ac (makeinfo version number): Allow for texinfo versions
	between 4.10 and 4.99.
	* configure: Regenerate.

Index: configure.ac
===================================================================
RCS file: /cvs/src/src/configure.ac,v
retrieving revision 1.30
diff -u -p -r1.30 configure.ac
--- configure.ac	1 Oct 2007 07:55:47 -0000	1.30
+++ configure.ac	9 Oct 2007 23:39:39 -0000
@@ -2504,7 +2504,7 @@ changequote(,)
     # For an installed makeinfo, we require it to be from texinfo 4.6
or
     # higher, else we use the "missing" dummy.
     if ${MAKEINFO} --version \
-       | egrep 'texinfo[^0-9]*(4\.([6-9]|[1-9][0-9])|[5-9]|[1-9][0-9])'
>/dev/null 2>&1; then
+       | egrep 'texinfo[^0-9]*(4\.([6-9]|4
\.[1-9][0-9]|[1-9][0-9])|[5-9]|[1-9][0-9])' >/dev/null 2>&1; then
       :
     else
       MAKEINFO="$MISSING makeinfo"
Index: configure
===================================================================
RCS file: /cvs/src/src/configure,v
retrieving revision 1.282
diff -u -p -r1.282 configure
--- configure	1 Oct 2007 09:04:55 -0000	1.282
+++ configure	9 Oct 2007 23:39:43 -0000
@@ -6233,7 +6233,7 @@ case " $build_configdirs " in
     # For an installed makeinfo, we require it to be from texinfo 4.6
or
     # higher, else we use the "missing" dummy.
     if ${MAKEINFO} --version \
-       | egrep 'texinfo[^0-9]*(4\.([6-9]|[1-9][0-9])|[5-9]|[1-9][0-9])'
>/dev/null 2>&1; then
+       | egrep 'texinfo[^0-9]*(4\.([6-9]|4
\.[1-9][0-9]|[1-9][0-9])|[5-9]|[1-9][0-9])' >/dev/null 2>&1; then
       :
     else
       MAKEINFO="$MISSING makeinfo"

Re: [RFA] top level configure and makeinfo/texinfo

[DJ Delorie]

> -       | egrep 'texinfo[^0-9]*(4\.([6-9]|[1-9][0-9])|[5-9]|[1-9][0-9])' >/dev/null 2>&1; then
> +       | egrep 'texinfo[^0-9]*(4\.([6-9]|4\.[1-9][0-9]|[1-9][0-9])|[5-9]|[1-9][0-9])' >/dev/null 2>&1; then

Um, the first matches:
	4.[6-9]
	4.[1-9][0-9]
	[5-9].*
	[1-9][0-9].*

Yours matches:
	4.[6-9]
	4.4.[1-9][0-9]
	4.[1-9][0-9]
	[5-9].*
	[1-9][0-9].*

I don't think this is what you want.

Re: [RFA] top level configure and makeinfo/texinfo

[Michael Snyder]

On Tue, 2007-10-09 at 21:11 -0400, DJ Delorie wrote:
> > -       | egrep 'texinfo[^0-9]*(4\.([6-9]|[1-9][0-9])|[5-9]|[1-9][0-9])' >/dev/null 2>&1; then
> > +       | egrep 'texinfo[^0-9]*(4\.([6-9]|4\.[1-9][0-9]|[1-9][0-9])|[5-9]|[1-9][0-9])' >/dev/null 2>&1; then
> 
> Um, the first matches:
> 	4.[6-9]
> 	4.[1-9][0-9]
> 	[5-9].*
> 	[1-9][0-9].*
> 
> Yours matches:
> 	4.[6-9]
> 	4.4.[1-9][0-9]
> 	4.[1-9][0-9]
> 	[5-9].*
> 	[1-9][0-9].*
> 
> I don't think this is what you want.

Oops, sorry, looks like I applied my change on top of one
that was committed by Alan Modra about 3 weeks ago.

Never mind, patch withdrawn.  You guys are way ahead of me.