From: Daniel Jacobowitz <drow@false.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Avoid builtin_type_int during type construction
Date: Wed, 03 Oct 2007 21:16:00 -0000 [thread overview]
Message-ID: <20071003211640.GA20141@caradoc.them.org> (raw)
In-Reply-To: <200710032112.l93LCA5w001163@brahms.sibelius.xs4all.nl>
On Wed, Oct 03, 2007 at 11:12:11PM +0200, Mark Kettenis wrote:
> > 2007-10-03 Daniel Jacobowitz <dan@codesourcery.com>
> >
> > * gdbtypes.c (create_range_type): Do not set TYPE_FIELD_TYPE for the
> > bounds.
> > (init_vector_type): Use builtin_type_int32.
>
> This must be wrong somehow; int isn't necessarily a 32-bit type.
This is not the type of the vector; it's the type of the index
(subscript) of a built-in vector type. I don't think it matters as
long as it is big enough to hold the number of elements, and I've
never seen any vectors that wouldn't fit in builtin_type_int8.
It's definitely possible I overlooked something, though. Does the
range type get used for anything else?
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2007-10-03 21:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 20:41 Daniel Jacobowitz
2007-10-03 21:12 ` Mark Kettenis
2007-10-03 21:16 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071003211640.GA20141@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox