From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8264 invoked by alias); 3 Oct 2007 21:16:45 -0000 Received: (qmail 8254 invoked by uid 22791); 3 Oct 2007 21:16:44 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 03 Oct 2007 21:16:43 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 9E0BE98152; Wed, 3 Oct 2007 21:16:41 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 8565898100; Wed, 3 Oct 2007 21:16:41 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IdBaC-0005Fq-PO; Wed, 03 Oct 2007 17:16:40 -0400 Date: Wed, 03 Oct 2007 21:16:00 -0000 From: Daniel Jacobowitz To: Mark Kettenis Cc: gdb-patches@sourceware.org Subject: Re: [commit] Avoid builtin_type_int during type construction Message-ID: <20071003211640.GA20141@caradoc.them.org> Mail-Followup-To: Mark Kettenis , gdb-patches@sourceware.org References: <20071003204110.GA29601@caradoc.them.org> <200710032112.l93LCA5w001163@brahms.sibelius.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200710032112.l93LCA5w001163@brahms.sibelius.xs4all.nl> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-10/txt/msg00039.txt.bz2 On Wed, Oct 03, 2007 at 11:12:11PM +0200, Mark Kettenis wrote: > > 2007-10-03 Daniel Jacobowitz > > > > * gdbtypes.c (create_range_type): Do not set TYPE_FIELD_TYPE for the > > bounds. > > (init_vector_type): Use builtin_type_int32. > > This must be wrong somehow; int isn't necessarily a 32-bit type. This is not the type of the vector; it's the type of the index (subscript) of a built-in vector type. I don't think it matters as long as it is big enough to hold the number of elements, and I've never seen any vectors that wouldn't fit in builtin_type_int8. It's definitely possible I overlooked something, though. Does the range type get used for anything else? -- Daniel Jacobowitz CodeSourcery