Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] ARI fixes: Remove 4 PARAMS in objc-exp.y
@ 2007-10-03  9:55 Pierre Muller
  2007-10-03 19:05 ` Daniel Jacobowitz
  0 siblings, 1 reply; 4+ messages in thread
From: Pierre Muller @ 2007-10-03  9:55 UTC (permalink / raw)
  To: gdb-patches

  As we recently added the lex and yacc files
to the ARI checks, some problems, that did not show
up, resurfaced.

  The obsolete use of PARAMS appears in
a single file: objc-exp.y

PARAMS	4	Do not use PARAMS(), ISO C 90 implies prototypes

OK to commit?

Pierre Muller

    

 Changelog entry:

2007-10-03  Pierre Muller  <muller@ics.u-strasbg.fr>

        * objc-exp.y: ARI fix: remove 4 PARAMS.



Index: objc-exp.y
===================================================================
RCS file: /cvs/src/src/gdb/objc-exp.y,v
retrieving revision 1.24
diff -u -p -r1.24 objc-exp.y
--- objc-exp.y  12 Jun 2007 15:33:04 -0000      1.24
+++ objc-exp.y  3 Oct 2007 09:50:17 -0000
@@ -108,13 +108,13 @@
 #endif

 int
-yyparse PARAMS ((void));
+yyparse (void);

 static int
-yylex PARAMS ((void));
+yylex (void);

 void
-yyerror PARAMS ((char *));
+yyerror (char *);

 %}

@@ -151,7 +151,7 @@ yyerror PARAMS ((char *));
 %{
 /* YYSTYPE gets defined by %union.  */
 static int
-parse_number PARAMS ((char *, int, int, YYSTYPE *));
+parse_number (char *, int, int, YYSTYPE *);
 %}

 %type <voidval> exp exp1 type_exp start variable qualified_name lcurly




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFA] ARI fixes: Remove 4 PARAMS in objc-exp.y
  2007-10-03  9:55 [RFA] ARI fixes: Remove 4 PARAMS in objc-exp.y Pierre Muller
@ 2007-10-03 19:05 ` Daniel Jacobowitz
  2007-10-05  6:48   ` Pierre Muller
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Jacobowitz @ 2007-10-03 19:05 UTC (permalink / raw)
  To: Pierre Muller; +Cc: gdb-patches

On Wed, Oct 03, 2007 at 11:55:04AM +0200, Pierre Muller wrote:
> OK to commit?

Yes, thanks.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [RFA] ARI fixes: Remove 4 PARAMS in objc-exp.y
  2007-10-03 19:05 ` Daniel Jacobowitz
@ 2007-10-05  6:48   ` Pierre Muller
  2007-10-05  8:57     ` Joel Brobecker
  0 siblings, 1 reply; 4+ messages in thread
From: Pierre Muller @ 2007-10-05  6:48 UTC (permalink / raw)
  To: 'Daniel Jacobowitz'; +Cc: gdb-patches

Done thanks.

  By the way, I hesitated
to change the date for the ChangeLog entry..
I finally kept 2007-10-03 as in my RFA,
is this OK or should I have changed it to 2007-10-04
which is the real commit date?

Pierre Muller

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Daniel Jacobowitz
> Sent: Wednesday, October 03, 2007 9:05 PM
> To: Pierre Muller
> Cc: gdb-patches@sourceware.org
> Subject: Re: [RFA] ARI fixes: Remove 4 PARAMS in objc-exp.y
> 
> On Wed, Oct 03, 2007 at 11:55:04AM +0200, Pierre Muller wrote:
> > OK to commit?
> 
> Yes, thanks.
> 
> --
> Daniel Jacobowitz
> CodeSourcery




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFA] ARI fixes: Remove 4 PARAMS in objc-exp.y
  2007-10-05  6:48   ` Pierre Muller
@ 2007-10-05  8:57     ` Joel Brobecker
  0 siblings, 0 replies; 4+ messages in thread
From: Joel Brobecker @ 2007-10-05  8:57 UTC (permalink / raw)
  To: Pierre Muller; +Cc: 'Daniel Jacobowitz', gdb-patches

> By the way, I hesitated to change the date for the ChangeLog entry..
> I finally kept 2007-10-03 as in my RFA, is this OK or should I have
> changed it to 2007-10-04 which is the real commit date?

Yep, you should use the commit date.

-- 
Joel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-10-05  8:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-10-03  9:55 [RFA] ARI fixes: Remove 4 PARAMS in objc-exp.y Pierre Muller
2007-10-03 19:05 ` Daniel Jacobowitz
2007-10-05  6:48   ` Pierre Muller
2007-10-05  8:57     ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox