From: Daniel Jacobowitz <drow@false.org>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: gdb-patches@sourceware.org, David Ung <davidu@mips.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: mips-tdep.c: Fix new-ABI handling of composite return values
Date: Tue, 25 Sep 2007 15:10:00 -0000 [thread overview]
Message-ID: <20070925151022.GA8482@caradoc.them.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0709251522080.6904@perivale.mips.com>
On Tue, Sep 25, 2007 at 03:50:26PM +0100, Maciej W. Rozycki wrote:
> 2007-09-25 David Ung <davidu@mips.com>
> Maciej W. Rozycki <macro@mips.com>
>
> * mips-tdep.c (mips_n32n64_return_value): Per N32/N64 ABI
> rules return composite types in registers as appropriate.
128-bit long double is also handled in this patch - that's not a
composite type. I think that's a merge error, though. If you look
above the float / double block you'll find another copy of
128-bit long double support in HEAD.
> else if (TYPE_CODE (type) == TYPE_CODE_STRUCT
> && TYPE_NFIELDS (type) <= 2
> && TYPE_NFIELDS (type) >= 1
> && ((TYPE_NFIELDS (type) == 1
> - && (TYPE_CODE (TYPE_FIELD_TYPE (type, 0))
> + && (TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (type, 0)))
Funny indentation. Is the only substantive change in this patch the
new calls to check_typedef?
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2007-09-25 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 14:50 Maciej W. Rozycki
2007-09-25 15:10 ` Daniel Jacobowitz [this message]
2007-09-25 15:48 ` Maciej W. Rozycki
2007-09-25 15:56 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925151022.GA8482@caradoc.them.org \
--to=drow@false.org \
--cc=davidu@mips.com \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox