From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19252 invoked by alias); 25 Sep 2007 15:10:28 -0000 Received: (qmail 19243 invoked by uid 22791); 25 Sep 2007 15:10:27 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 25 Sep 2007 15:10:25 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 64C30982AD; Tue, 25 Sep 2007 15:10:23 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 4452D980BD; Tue, 25 Sep 2007 15:10:23 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IaC3K-0002N2-6U; Tue, 25 Sep 2007 11:10:22 -0400 Date: Tue, 25 Sep 2007 15:10:00 -0000 From: Daniel Jacobowitz To: "Maciej W. Rozycki" Cc: gdb-patches@sourceware.org, David Ung , "Maciej W. Rozycki" Subject: Re: mips-tdep.c: Fix new-ABI handling of composite return values Message-ID: <20070925151022.GA8482@caradoc.them.org> Mail-Followup-To: "Maciej W. Rozycki" , gdb-patches@sourceware.org, David Ung , "Maciej W. Rozycki" References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00350.txt.bz2 On Tue, Sep 25, 2007 at 03:50:26PM +0100, Maciej W. Rozycki wrote: > 2007-09-25 David Ung > Maciej W. Rozycki > > * mips-tdep.c (mips_n32n64_return_value): Per N32/N64 ABI > rules return composite types in registers as appropriate. 128-bit long double is also handled in this patch - that's not a composite type. I think that's a merge error, though. If you look above the float / double block you'll find another copy of 128-bit long double support in HEAD. > else if (TYPE_CODE (type) == TYPE_CODE_STRUCT > && TYPE_NFIELDS (type) <= 2 > && TYPE_NFIELDS (type) >= 1 > && ((TYPE_NFIELDS (type) == 1 > - && (TYPE_CODE (TYPE_FIELD_TYPE (type, 0)) > + && (TYPE_CODE (check_typedef (TYPE_FIELD_TYPE (type, 0))) Funny indentation. Is the only substantive change in this patch the new calls to check_typedef? -- Daniel Jacobowitz CodeSourcery