[patch] restore skip_prologue comments

[patch] restore skip_prologue comments

[Thiago Jung Bauermann]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]

Hi,

For some reason, the comment explaining skip_prologue in rs6000-tdep.c
was separated from the function. This patch restores it to its due
place.
-- 
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center

[-- Attachment #2: rs6000-skip-prologue-comment.patch --]
[-- Type: text/x-patch, Size: 3123 bytes --]

2007-09-23  Thiago Jung Bauermann  <bauerman@br.ibm.com>

	* rs6000-tdep.c (skip_prologue): Restore comment with
	function description to its proper place.

Index: src-git/gdb/rs6000-tdep.c
===================================================================
--- src-git.orig/gdb/rs6000-tdep.c	2007-09-12 23:33:14.000000000 -0300
+++ src-git/gdb/rs6000-tdep.c	2007-09-12 23:34:14.000000000 -0300
@@ -943,29 +943,6 @@ rs6000_software_single_step (struct fram
 }
 
 
-/* return pc value after skipping a function prologue and also return
-   information about a function frame.
-
-   in struct rs6000_framedata fdata:
-   - frameless is TRUE, if function does not have a frame.
-   - nosavedpc is TRUE, if function does not save %pc value in its frame.
-   - offset is the initial size of this stack frame --- the amount by
-   which we decrement the sp to allocate the frame.
-   - saved_gpr is the number of the first saved gpr.
-   - saved_fpr is the number of the first saved fpr.
-   - saved_vr is the number of the first saved vr.
-   - saved_ev is the number of the first saved ev.
-   - alloca_reg is the number of the register used for alloca() handling.
-   Otherwise -1.
-   - gpr_offset is the offset of the first saved gpr from the previous frame.
-   - fpr_offset is the offset of the first saved fpr from the previous frame.
-   - vr_offset is the offset of the first saved vr from the previous frame.
-   - ev_offset is the offset of the first saved ev from the previous frame.
-   - lr_offset is the offset of the saved lr
-   - cr_offset is the offset of the saved cr
-   - vrsave_offset is the offset of the saved vrsave register
- */
-
 #define SIGNED_SHORT(x) 						\
   ((sizeof (short) == 2)						\
    ? ((int)(short)(x))							\
@@ -1077,6 +1054,29 @@ bl_to_blrl_insn_p (CORE_ADDR pc, int ins
   return 0;
 }
 
+/* return pc value after skipping a function prologue and also return
+   information about a function frame.
+
+   in struct rs6000_framedata fdata:
+   - frameless is TRUE, if function does not have a frame.
+   - nosavedpc is TRUE, if function does not save %pc value in its frame.
+   - offset is the initial size of this stack frame --- the amount by
+   which we decrement the sp to allocate the frame.
+   - saved_gpr is the number of the first saved gpr.
+   - saved_fpr is the number of the first saved fpr.
+   - saved_vr is the number of the first saved vr.
+   - saved_ev is the number of the first saved ev.
+   - alloca_reg is the number of the register used for alloca() handling.
+   Otherwise -1.
+   - gpr_offset is the offset of the first saved gpr from the previous frame.
+   - fpr_offset is the offset of the first saved fpr from the previous frame.
+   - vr_offset is the offset of the first saved vr from the previous frame.
+   - ev_offset is the offset of the first saved ev from the previous frame.
+   - lr_offset is the offset of the saved lr
+   - cr_offset is the offset of the saved cr
+   - vrsave_offset is the offset of the saved vrsave register
+ */
+
 static CORE_ADDR
 skip_prologue (CORE_ADDR pc, CORE_ADDR lim_pc, struct rs6000_framedata *fdata)
 {

Re: [patch] restore skip_prologue comments

[Joel Brobecker]

Hello Thiago,

> For some reason, the comment explaining skip_prologue in rs6000-tdep.c
> was separated from the function. This patch restores it to its due
> place.

Oh, you are right!

> 2007-09-23  Thiago Jung Bauermann  <bauerman@br.ibm.com>
> 
>         * rs6000-tdep.c (skip_prologue): Restore comment with
>         function description to its proper place.

This is OK (obvious if you ask me). Thank you!

-- 
Joel

Re: [patch] restore skip_prologue comments

[Thiago Jung Bauermann]

On Sun, 2007-09-23 at 20:53 -0700, Joel Brobecker wrote:
> Hello Thiago,
> 
> > For some reason, the comment explaining skip_prologue in rs6000-tdep.c
> > was separated from the function. This patch restores it to its due
> > place.
> 
> Oh, you are right!
> 
> > 2007-09-23  Thiago Jung Bauermann  <bauerman@br.ibm.com>
> > 
> >         * rs6000-tdep.c (skip_prologue): Restore comment with
> >         function description to its proper place.
> 
> This is OK (obvious if you ask me). Thank you!

Commited. Thanks!
-- 
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center