From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
Cc: mark.kettenis@xs4all.nl, gdb-patches@sourceware.org
Subject: Re: [RFC/commit] Getting rid of tm-rs6000.h (PROCESS_LINENUMBER_HOOK)
Date: Thu, 20 Sep 2007 09:04:00 -0000 [thread overview]
Message-ID: <200709200904.l8K94SPW026887@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20070920063714.GA16312@adacore.com> (message from Joel Brobecker on Wed, 19 Sep 2007 23:37:14 -0700)
> Date: Wed, 19 Sep 2007 23:37:14 -0700
> From: Joel Brobecker <brobecker@adacore.com>
>
> Hi Mark,
>
> > > The AIX port is the only port that defines this macro, and it's only
> > > used in one place: buildsym.c:end_symtab(). I think the most appropriate
> > > way to define this notion is as a gdbarch method, set only in the case
> > > of AIX. This is what this patch does.
> >
> > Hmm, if this is something that is purely for a specific object/debug format,
> > I think the gdbarch vector is the wrong place to put it.
>
> Since the gdbarch vector is dependent on the ABI, we can set the method
> when identifying XCOFF objects. That seemed the simplest approach at
> the time. But I agree that this is borderline. What do you think about
> adding a new method inside struct sym_fns:
>
> void (*sym_read_linetable) (void)
>
> It would be null for all object formats except XCOFF.
>
> I'll experiment with that... Thanks for your feedback!
Seems like a better approach to me.
next prev parent reply other threads:[~2007-09-20 9:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 23:15 Joel Brobecker
2007-09-20 6:10 ` Mark Kettenis
2007-09-20 6:37 ` Joel Brobecker
2007-09-20 9:04 ` Mark Kettenis [this message]
2007-09-20 21:13 ` Joel Brobecker
2007-09-21 7:48 ` Mark Kettenis
2007-09-21 18:03 ` Joel Brobecker
2007-10-02 17:38 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709200904.l8K94SPW026887@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox