From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50859-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18947 invoked by alias); 20 Sep 2007 09:04:59 -0000
Received: (qmail 18923 invoked by uid 22791); 20 Sep 2007 09:04:55 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Sep 2007 09:04:50 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.0) with ESMTP id l8K94Sie007967; 	Thu, 20 Sep 2007 11:04:28 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id l8K94SPW026887; 	Thu, 20 Sep 2007 11:04:28 +0200 (CEST)
Date: Thu, 20 Sep 2007 09:04:00 -0000
Message-Id: <200709200904.l8K94SPW026887@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com
CC: mark.kettenis@xs4all.nl, gdb-patches@sourceware.org
In-reply-to: <20070920063714.GA16312@adacore.com> (message from Joel Brobecker 	on Wed, 19 Sep 2007 23:37:14 -0700)
Subject: Re: [RFC/commit] Getting rid of tm-rs6000.h (PROCESS_LINENUMBER_HOOK)
References: <20070918231448.GS29127@adacore.com> <200709200610.l8K6AeV1018876@brahms.sibelius.xs4all.nl> <20070920063714.GA16312@adacore.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-09/txt/msg00268.txt.bz2

> Date: Wed, 19 Sep 2007 23:37:14 -0700
> From: Joel Brobecker <brobecker@adacore.com>
> 
> Hi Mark,
> 
> > > The AIX port is the only port that defines this macro, and it's only
> > > used in one place: buildsym.c:end_symtab(). I think the most appropriate
> > > way to define this notion is as a gdbarch method, set only in the case
> > > of AIX. This is what this patch does.
> > 
> > Hmm, if this is something that is purely for a specific object/debug format,
> > I think the gdbarch vector is the wrong place to put it.
> 
> Since the gdbarch vector is dependent on the ABI, we can set the method
> when identifying XCOFF objects. That seemed the simplest approach at
> the time.  But I agree that this is borderline. What do you think about
> adding a new method inside struct sym_fns: 
> 
>         void (*sym_read_linetable) (void)
> 
> It would be null for all object formats except XCOFF.
> 
> I'll experiment with that... Thanks for your feedback!

Seems like a better approach to me.