Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Jerome Guitton <guitton@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] dwarf2loc, guard against null
Date: Mon, 17 Sep 2007 12:15:00 -0000	[thread overview]
Message-ID: <20070917121503.GA7606@caradoc.them.org> (raw)
In-Reply-To: <20070917120443.GA21276@adacore.com>

On Mon, Sep 17, 2007 at 02:04:43PM +0200, Jerome Guitton wrote:
> 
> get_frame_function can return null; in this case, crash...
> 
> OK to apply?
> 
> 2007-09-17  Jerome Guitton  <guitton@adacore.com>
> 
> 	* dwarf2loc.c (dwarf_expr_frame_base): Guard against NULL.

I'm not sure - there must be another bug so it might be this should be
a gdb_assert instead.  The DW_AT_frame_base that brought us here came
from .debug_info inside an entry for a function.  So we must have
found the function at some point.  But we didn't find the function
this time - why not?

-- 
Daniel Jacobowitz
CodeSourcery


  reply	other threads:[~2007-09-17 12:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-17 12:04 Jerome Guitton
2007-09-17 12:15 ` Daniel Jacobowitz [this message]
2007-09-17 12:27   ` Jerome Guitton
2007-09-17 12:30     ` Daniel Jacobowitz
2007-09-17 13:10       ` Jerome Guitton
2007-09-17 13:20         ` Daniel Jacobowitz
2007-09-17 13:42           ` Jerome Guitton
2007-09-17 13:52             ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070917121503.GA7606@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=guitton@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox