From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5162 invoked by alias); 17 Sep 2007 12:15:22 -0000 Received: (qmail 5140 invoked by uid 22791); 17 Sep 2007 12:15:19 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Sep 2007 12:15:07 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 7B1119810B; Mon, 17 Sep 2007 12:15:05 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 35A2B9810A; Mon, 17 Sep 2007 12:15:05 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.67) (envelope-from ) id 1IXFVH-0001zH-MD; Mon, 17 Sep 2007 08:15:03 -0400 Date: Mon, 17 Sep 2007 12:15:00 -0000 From: Daniel Jacobowitz To: Jerome Guitton Cc: gdb-patches@sourceware.org Subject: Re: [RFA] dwarf2loc, guard against null Message-ID: <20070917121503.GA7606@caradoc.them.org> Mail-Followup-To: Jerome Guitton , gdb-patches@sourceware.org References: <20070917120443.GA21276@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070917120443.GA21276@adacore.com> User-Agent: Mutt/1.5.15 (2007-04-09) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00211.txt.bz2 On Mon, Sep 17, 2007 at 02:04:43PM +0200, Jerome Guitton wrote: > > get_frame_function can return null; in this case, crash... > > OK to apply? > > 2007-09-17 Jerome Guitton > > * dwarf2loc.c (dwarf_expr_frame_base): Guard against NULL. I'm not sure - there must be another bug so it might be this should be a gdb_assert instead. The DW_AT_frame_base that brought us here came from .debug_info inside an entry for a function. So we must have found the function at some point. But we didn't find the function this time - why not? -- Daniel Jacobowitz CodeSourcery