From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@sonic.net
Cc: brobecker@adacore.com, msnyder@sonic.net, gdb-patches@sourceware.org
Subject: Re: [patch] strlen(null) in dwarf2read
Date: Wed, 05 Sep 2007 07:26:00 -0000 [thread overview]
Message-ID: <200709050725.l857Pw2p015990@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <4144.12.7.175.2.1188951036.squirrel@webmail.sonic.net> (msnyder@sonic.net)
> Date: Tue, 4 Sep 2007 17:10:36 -0700 (PDT)
> From: msnyder@sonic.net
>
> >> 2007-08-29 Michael Snyder <msnyder@access-company.com>
> >>
> >> * dwarf2read.c (determine_prefix): Do not send NULL to strlen.
> >
> > Proofread, and no comment :)
> >
> > (actually, yes: I'm much better at reading unified diff, not sure
> > about others - I ended up applying your patch locally and regenerating
> > the diff)
>
> All right. The reason I like -p is because it gives me the
> function name for context. I can see that -u is more concise.
>
> Wonder if there is a way to get the best of both?
-up works like a charm ;)
prev parent reply other threads:[~2007-09-05 7:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-29 21:49 msnyder
2007-09-04 14:25 ` Joel Brobecker
2007-09-05 0:10 ` msnyder
2007-09-05 0:53 ` Daniel Jacobowitz
2007-09-05 1:11 ` msnyder
2007-09-05 7:26 ` Mark Kettenis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709050725.l857Pw2p015990@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@sonic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox