From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-50659-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12826 invoked by alias); 5 Sep 2007 07:26:20 -0000
Received: (qmail 12812 invoked by uid 22791); 5 Sep 2007 07:26:19 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO brahms.sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 05 Sep 2007 07:26:14 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.0) with ESMTP id l857Q01I027349; 	Wed, 5 Sep 2007 09:26:00 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.1/8.14.1/Submit) id l857Pw2p015990; 	Wed, 5 Sep 2007 09:25:58 +0200 (CEST)
Date: Wed, 05 Sep 2007 07:26:00 -0000
Message-Id: <200709050725.l857Pw2p015990@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: msnyder@sonic.net
CC: brobecker@adacore.com, msnyder@sonic.net, gdb-patches@sourceware.org
In-reply-to: <4144.12.7.175.2.1188951036.squirrel@webmail.sonic.net> 	(msnyder@sonic.net)
Subject: Re: [patch] strlen(null) in dwarf2read
References: <15003.12.7.175.2.1188424188.squirrel@webmail.sonic.net>     <20070904142440.GD3579@adacore.com> <4144.12.7.175.2.1188951036.squirrel@webmail.sonic.net>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-09/txt/msg00068.txt.bz2

> Date: Tue, 4 Sep 2007 17:10:36 -0700 (PDT)
> From: msnyder@sonic.net
> 
> >> 2007-08-29  Michael Snyder  <msnyder@access-company.com>
> >>
> >> 	* dwarf2read.c (determine_prefix): Do not send NULL to strlen.
> >
> > Proofread, and no comment :)
> >
> > (actually, yes: I'm much better at reading unified diff, not sure
> > about others - I ended up applying your patch locally and regenerating
> > the diff)
> 
> All right.  The reason I like -p is because it gives me the
> function name for context.  I can see that -u is more concise.
> 
> Wonder if there is a way to get the best of both?

-up works like a charm ;)