Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: msnyder@sonic.net
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] expprint.c, check strchr return val for null.
Date: Tue, 04 Sep 2007 14:30:00 -0000	[thread overview]
Message-ID: <20070904143037.GE3579@adacore.com> (raw)
In-Reply-To: <17390.12.7.175.2.1188425405.squirrel@webmail.sonic.net>

> 2007-08-29  Michael Snyder  <msnyder@access-company.com>
> 
> 	* expprint.c (print_subexp_standard): Check strchr for null.

The extra assert looks good to me. But make sure to update Makefile.in
as well since you introduced a dependency on gdb_assert.h.

Thanks for all these patches!

-- 
Joel


  reply	other threads:[~2007-09-04 14:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-29 22:10 msnyder
2007-09-04 14:30 ` Joel Brobecker [this message]
2007-09-05  0:13   ` msnyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070904143037.GE3579@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@sonic.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox