From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9431 invoked by alias); 4 Sep 2007 14:30:46 -0000 Received: (qmail 9355 invoked by uid 22791); 4 Sep 2007 14:30:44 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 04 Sep 2007 14:30:39 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id B11AA2AA7C6; Tue, 4 Sep 2007 10:30:37 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YJADTPWDfbND; Tue, 4 Sep 2007 10:30:37 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 90B842AA4CE; Tue, 4 Sep 2007 10:30:37 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 4E772E7B58; Tue, 4 Sep 2007 07:30:37 -0700 (PDT) Date: Tue, 04 Sep 2007 14:30:00 -0000 From: Joel Brobecker To: msnyder@sonic.net Cc: gdb-patches@sourceware.org Subject: Re: [patch] expprint.c, check strchr return val for null. Message-ID: <20070904143037.GE3579@adacore.com> References: <17390.12.7.175.2.1188425405.squirrel@webmail.sonic.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17390.12.7.175.2.1188425405.squirrel@webmail.sonic.net> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00050.txt.bz2 > 2007-08-29 Michael Snyder > > * expprint.c (print_subexp_standard): Check strchr for null. The extra assert looks good to me. But make sure to update Makefile.in as well since you introduced a dependency on gdb_assert.h. Thanks for all these patches! -- Joel