From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: Back-Cover Text and --version updates
Date: Sun, 02 Sep 2007 20:59:00 -0000 [thread overview]
Message-ID: <20070902205855.GA6164@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20070902200216.GA21817@caradoc.them.org>
[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]
On Sun, 02 Sep 2007 22:02:16 +0200, Daniel Jacobowitz wrote:
...
> Thanks for the review. I've checked it in now.
gcc-4.1.2-17.x86_64
gcc -c -m64 -ggdb2 -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -I. -I.././gdb -I.././gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I.././gdb/../include/opcode -I.././gdb/../readline/.. -I../bfd -I.././gdb/../bfd -I.././gdb/../include -DMI_OUT=1 -DTUI=1 -Wall -Wdeclaration-after-statement -Wpointer-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wno-switch -Wno-char-subscripts -Werror top.c
top.c: In function ‘print_gdb_version’:
top.c:1157: error: missing terminating " character
top.c:1161: error: stray ‘\’ in program
top.c:1161: error: ‘and’ undeclared (first use in this function)
top.c:1161: error: (Each undeclared identifier is reported only once
top.c:1161: error: for each function it appears in.)
top.c:1161: error: expected ‘)’ before string constant
cc1: warnings being treated as errors
top.c:1161: warning: format not a string literal and no format arguments
make[2]: *** [top.o] Error 1
I expect I do not have to ask for such commit approval.
Regards,
Jan
[-- Attachment #2: gdb-eol.patch --]
[-- Type: text/plain, Size: 734 bytes --]
2007-09-02 Jan Kratochvil <jan.kratochvil@redhat.com>
* top.c (print_gdb_version): Fixed an end-of-line compiler error.
--- gdb/top.c 2 Sep 2007 20:02:12 -0000 1.124
+++ gdb/top.c 2 Sep 2007 20:55:35 -0000
@@ -1157,7 +1157,7 @@ print_gdb_version (struct ui_file *strea
fprintf_filtered (stream, "\
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>\n\
This is free software: you are free to change and redistribute it.\n\
-There is NO WARRANTY, to the extent permitted by law. Type \"show copying\"
+There is NO WARRANTY, to the extent permitted by law. Type \"show copying\"\n\
and \"show warranty\" for details.\n");
/* After the required info we print the configuration information. */
next prev parent reply other threads:[~2007-09-02 20:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-02 14:09 Daniel Jacobowitz
2007-09-02 19:44 ` Eli Zaretskii
2007-09-02 20:02 ` Daniel Jacobowitz
2007-09-02 20:59 ` Jan Kratochvil [this message]
2007-09-02 21:29 ` Daniel Jacobowitz
2007-09-03 9:29 ` [testsuite patch approval?] " Jan Kratochvil
2007-09-03 14:53 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070902205855.GA6164@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox